Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Publish nightly knative/eventing-sources releases to knative-nightly #132

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Publish nightly knative/eventing-sources releases to knative-nightly #132

merged 1 commit into from
Nov 30, 2018

Conversation

adrcunha
Copy link
Contributor

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 30, 2018
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2018
grantr
grantr approved these changes Nov 30, 2018
View reviewed changes
Copy link
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2018
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, grantr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 4338ed7 into knative:master Nov 30, 2018
srvaroa added a commit to srvaroa/eventing-sources that referenced this pull request Dec 5, 2018
@srvaroa
Merge branch 'master' of github.com:knative/eventing-sources
a639152 
* 'master' of github.com:knative/eventing-sources:
  Make verify-codegen.sh also check /vendor (knative#133)
  Add @Harwayne as reviewer (knative#136)
  Publish nightly knative/eventing-sources releases to knative-nightly (knative#132)
  Remove images deletion step from e2e test / Update test-infra (knative#131)
  Update pkg, ignoring severity in tests (knative#130)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grantr grantr grantr approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

Assignees

@grantr grantr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrcunha @knative-prow-robot @grantr