Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct syntax of build example #1289

Merged
merged 2 commits into from
May 17, 2019
Merged

Correct syntax of build example #1289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cda91fd
Correct syntax of build example
johscheuer May 8, 2019
2ac0b84
Correct build example
johscheuer May 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions docs/build/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,7 @@ spec:
steps:
- name: ubuntu-example
image: ubuntu
args: ["ubuntu-build-example", "SECRETS-example.md"]
steps:
args: ['ubuntu-build-example', 'SECRETS-example.md']
- image: gcr.io/example-builders/build-example
args: ['echo', 'hello-example', 'build']
```
Expand Down
7 changes: 2 additions & 5 deletions docs/build/builds.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,8 @@ spec:
- name: ubuntu-example
image: ubuntu
args: ["ubuntu-build-example", "SECRETS-example.md"]
steps:
- image: gcr.io/example-builders/build-example
args: ['echo', 'hello-example', 'build']
steps:
- name: dockerfile-pushexample
image: gcr.io/example-builders/push-example
args: ["push", "${IMAGE}"]
Expand All @@ -93,10 +91,9 @@ spec:

#### Steps

The `steps` field is required if the `template` field is not defined. You define
one or more `steps` fields to define the body of a build.
The `steps` field is required if the `template` field is not defined.

Each `steps` in a build must specify a `Builder`, or type of container image
Each `steps` field in a build must specify a `Builder`, or type of container image
that adheres to the [Knative builder contract](./builder-contract.md). For each
of the `steps` fields, or container images that you define:

Expand Down