Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct syntax of build example #1289

Merged
merged 2 commits into from
May 17, 2019

Conversation

johscheuer
Copy link
Contributor

This PR corrects the build example which defines two build steps with the previous version only one step will be executed (this is actually an bug in knative build, I will create another issue in the according repo).

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 8, 2019
@knative-prow-robot knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 8, 2019
@knative-prow-robot
Copy link
Contributor

Hi @johscheuer. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johscheuer
Copy link
Contributor Author

/label cherrypick-0.5

@johscheuer
Copy link
Contributor Author

I will fix the other build docs too

@RichieEscarez RichieEscarez added the triage/needs-eng-input Engineering input is requested label May 8, 2019
@sebgoa
Copy link
Contributor

sebgoa commented May 9, 2019

that's correct, good catch

/lgtm

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 9, 2019
@imjasonh
Copy link
Member

imjasonh commented May 9, 2019

/lgtm

@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 10, 2019
@johscheuer
Copy link
Contributor Author

I finally reviewed and corrected all build examples

@RichieEscarez
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johscheuer, RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 8586421 into knative:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/needs-eng-input Engineering input is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants