Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.15.2 release backports #886

Merged
merged 1 commit into from
Jun 16, 2020
Merged

v0.15.2 release backports #886

merged 1 commit into from
Jun 16, 2020

Conversation

navidshaikh
Copy link
Collaborator

@navidshaikh navidshaikh commented Jun 16, 2020 •
edited
Loading

Description

client v0.15.2 release backports with a bug fix and pinning go 1.14 in go.mod (inline with serving v0.15.x release).

Changes

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Indicates the PR's author has not signed the CLA. label Jun 16, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 16, 2020
@navidshaikh
Copy link
Collaborator Author

@danielhelfand @dprotaso : Can you please add consent for CLA check ?

@navidshaikh navidshaikh added the backport/pr A backport PR which is target to a release branch. label Jun 16, 2020
@navidshaikh
Copy link
Collaborator Author

@googlebot I consent.

/retest

@navidshaikh navidshaikh force-pushed the pr/v0.15.2 branch 2 times, most recently from 9727fdc to a02b444 Compare June 16, 2020 13:04
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Jun 16, 2020
@danielhelfand
Copy link
Contributor

@danielhelfand @dprotaso : Can you please add consent for CLA check ?

@googlebot I consent.

rhuss
rhuss reviewed Jun 16, 2020
View reviewed changes
hack/build.sh Outdated Show resolved Hide resolved
rhuss
rhuss requested changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lloks good except that we have to backport the build.sh fix, too. #882 is it.

@navidshaikh
Backports for client v0.15.2 release
88f15b4 
 - Updates the vendor/modules.txt
 - Update CHANGELOG
 - Squashed commits for
   knative#866
   knative#880
   knative#883
rhuss
rhuss approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit efc9df1 into knative:release-0.15 Jun 16, 2020
@navidshaikh navidshaikh deleted the pr/v0.15.2 branch June 16, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhuss rhuss rhuss approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

@maximilien maximilien Awaiting requested review from maximilien

Assignees

@rhuss rhuss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport/pr A backport PR which is target to a release branch. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@navidshaikh @googlebot @danielhelfand @knative-prow-robot @rhuss