Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build.sh for macOs users #883

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Fix build.sh for macOs users #883

merged 2 commits into from
Jun 9, 2020

Conversation

rhuss
Copy link
Contributor

@rhuss rhuss commented Jun 9, 2020

Fixes #882

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 9, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 9, 2020
maximilien
maximilien approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit ff350fb into knative:master Jun 9, 2020
rhuss added a commit to rhuss/knative-client that referenced this pull request Jun 10, 2020
@rhuss
Fix build.sh for macOs users (knative#883)
77b53e2 
* Fix build.sh for macOs users

Fixes knative#882

* cleanup tempdir after installing
@navidshaikh navidshaikh added the backport/candidate Consider this PR to be backported to the release branch label Jun 16, 2020
navidshaikh added a commit to navidshaikh/client that referenced this pull request Jun 16, 2020
@navidshaikh
Backports for client v0.15.2 release
88f15b4 
 - Updates the vendor/modules.txt
 - Update CHANGELOG
 - Squashed commits for
   knative#866
   knative#880
   knative#883
@navidshaikh navidshaikh mentioned this pull request Jun 16, 2020
Merged
knative-prow-robot pushed a commit that referenced this pull request Jun 16, 2020
@navidshaikh
Backports for client v0.15.2 release (#886)
efc9df1 
- Updates the vendor/modules.txt
 - Update CHANGELOG
 - Squashed commits for
   #866
   #880
   #883
@navidshaikh navidshaikh added backported-to/0.15 and removed backport/candidate Consider this PR to be backported to the release branch labels Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilien maximilien maximilien approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

Assignees

@maximilien maximilien

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build.sh is broken for macOs users
5 participants
@rhuss @knative-prow-robot @maximilien @navidshaikh @googlebot