-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(source binding): Support for Sink Binding as source #625
Conversation
One question to the community: I would like to include this feature into 0.12.0 which is due tomorrow. However, because of time constraints and outstanding review, I would suggest to postpone the release to Wednesday (and I would some help with some quick reviewers ;-) wdyt ? We can discuss this tomorrown on the WG call, however as I'm on a train at that time, not sure how it will work out for me. // cc: @sixolet @maximilien @navidshaikh |
Sink bindings are managed like any other source. Sinks are specified as usual (with prefix and name), 'subjects' (the other end of the binding) is managed via a shortcut notation: * with name: `<kind>:<apiVersion>:<name>` * with label selector: `<kind>:<apiVersion>:key1=value1,key2=value2` With `--subject-namespace` and additional namespace can be provided (shoudl be possible for a sink, too but is not yet) The implementation already uses the new sink binding from the `sources.knative.dev` group and hence is a bit inconsistent to the still old usage kf `sources.eventing.knative.dev` for apiserver source and cronjob. However as we will move over to `sources.knative.dev` very soon (right after v0.12.0) release, this is was more appropriates. Still WIP, but eventually fixes knative#624 Task list: - [X] create - [] update - [] delete - [] describe - [] list
Also, it looks like that knative eventing 0.12.0 is still on the old api group. So I need to move this code to use the legacyclient, too, for the sink binding and only switch over to the new client for 0.13.0
* update * delete * list * describe
…nt b set. Tuned describe output a bit.
ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not manually test. Left various small comments. LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maximilien, rhuss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@navidshaikh @maximilien just worked on the comments, thanks for the feedback ! Very helpful.
Going to push in a second with most of the comments fixed. Some are discussable but I'm sure we can resolved those, too.
The following is the coverage report on the affected files.
|
/lgtm |
Sink bindings are managed like any other source. Sinks are specified as usual (with prefix and name),
'subjects' (the other end of the binding) is managed via a shortcut notation:
<kind>:<apiVersion>:<name>
<kind>:<apiVersion>:key1=value1,key2=value2
WithAs discussed on Slack, neither for a sink nor a subject the namespace is setable by the user. So I removed that option.--subject-namespace
and additional namespace can be provided (shoudl be possible for a sink, too but is not yet)The implementation already uses the new sink binding from the
sources.knative.dev
groupand hence is a bit inconsistent to the still old usage kf
sources.eventing.knative.dev
for apiserver source and cronjob.However as we will move over to
sources.knative.dev
very soon (right after v0.12.0) release,this is was more appropriates.
Still WIP, but eventually fixes #624
Task list: