Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kn source binding ... command #624

Closed
rhuss opened this issue Jan 27, 2020 · 0 comments · Fixed by #625
Closed

Add kn source binding ... command #624

rhuss opened this issue Jan 27, 2020 · 0 comments · Fixed by #625
Assignees
@rhuss
Labels
kind/feature New feature or request

Comments

@rhuss
Copy link
Contributor

rhuss commented Jan 27, 2020

kn source binding set of commands should be added, perferably still for v0.12.0

The tricky part will be how to specify the subject. That probably needs to be split over multiple options like in --subject apiVersion:kind:name or --subject apiVersion:kind --match labelkey1:labelvalue1 --match labelkey2:labelvalue2
@rhuss rhuss added the kind/feature New feature or request label Jan 27, 2020
@rhuss rhuss self-assigned this Jan 27, 2020
rhuss added a commit to rhuss/knative-client that referenced this issue Jan 27, 2020
@rhuss
feature(source binding): Support for Sink Binding as source
a332ff2 
Sink bindings are managed like any other source. Sinks are specified as usual (with prefix and name),
'subjects' (the other end of the binding) is managed via a shortcut notation:

* with name: `<kind>:<apiVersion>:<name>`
* with label selector: `<kind>:<apiVersion>:key1=value1,key2=value2`

With `--subject-namespace` and additional namespace can be provided (shoudl be possible for a sink, too but is not yet)

The implementation already uses the new sink binding from the `sources.knative.dev` group
and hence is a bit inconsistent to the still old usage kf `sources.eventing.knative.dev` for apiserver source and cronjob.

However as we will move over to `sources.knative.dev` very soon (right after v0.12.0) release,
this is was more appropriates.

Still WIP, but eventually fixes knative#624

Task list:

- [X] create
- [] update
- [] delete
- [] describe
- [] list
@rhuss rhuss mentioned this issue Jan 27, 2020
Merged
5 tasks
rhuss added a commit to rhuss/knative-client that referenced this issue Jan 28, 2020
@rhuss
feature(source binding): Support for Sink Binding as source
9fd3e52 
Sink bindings are managed like any other source. Sinks are specified as usual (with prefix and name),
'subjects' (the other end of the binding) is managed via a shortcut notation:

* with name: `<kind>:<apiVersion>:<name>`
* with label selector: `<kind>:<apiVersion>:key1=value1,key2=value2`

With `--subject-namespace` and additional namespace can be provided (shoudl be possible for a sink, too but is not yet)

The implementation already uses the new sink binding from the `sources.knative.dev` group
and hence is a bit inconsistent to the still old usage kf `sources.eventing.knative.dev` for apiserver source and cronjob.

However as we will move over to `sources.knative.dev` very soon (right after v0.12.0) release,
this is was more appropriates.

Still WIP, but eventually fixes knative#624

Task list:

- [X] create
- [] update
- [] delete
- [] describe
- [] list
knative-prow-robot pushed a commit that referenced this issue Jan 29, 2020
@rhuss
feature(source binding): Support for Sink Binding as source (#625)
164cb5f 
* feature(source binding): Support for Sink Binding as source

Sink bindings are managed like any other source. Sinks are specified as usual (with prefix and name),
'subjects' (the other end of the binding) is managed via a shortcut notation:

* with name: `<kind>:<apiVersion>:<name>`
* with label selector: `<kind>:<apiVersion>:key1=value1,key2=value2`

With `--subject-namespace` and additional namespace can be provided (shoudl be possible for a sink, too but is not yet)

The implementation already uses the new sink binding from the `sources.knative.dev` group
and hence is a bit inconsistent to the still old usage kf `sources.eventing.knative.dev` for apiserver source and cronjob.

However as we will move over to `sources.knative.dev` very soon (right after v0.12.0) release,
this is was more appropriates.

Still WIP, but eventually fixes #624

Task list:

- [X] create
- [] update
- [] delete
- [] describe
- [] list

* fix(source binding): Added missing commands

Also, it looks like that knative eventing 0.12.0 is still on the old api group.
So I need to move this code to use the legacyclient, too, for the sink binding
and only switch over to the new client for 0.13.0

* feature(source binding): Added missing subcommands

* update
* delete
* list
* describe

* fix(source binding): Removed --subject-namespace as this namespace cant b set.

Tuned describe output a bit.

* feat(source binding) add support for CeOverride

* fix: Worked on review comments

* fix: review comments

* fix: names in binding client
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@adrcunha @knative-prow-robot
Delete the continuous release-0.2 and release-0.3 integration flows (k…
76bcf9f 
…native#624)

They are extremely flaky and provide no value anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhuss rhuss

Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature(source binding): Support for Sink Binding as source rhuss/knative-client
1 participant
@rhuss