fixes(#598): checks for namespace creation instead of waiting

[maximilien]

Fixes #598

Proposed Changes

• checks for namespace creation instead of waiting

CHANGELOG.adoc:

• 🧽 Update or clean up current behaviour

[maximilien]

/ok-to-test

[rhuss]

CHANGELOG.adoc:

* 🧽 Update or clean up current behaviour

Thanks for giving the CHANGELOG some love here, but it would be easier for me (or whoever makes the next release) if you would add this directory to CHANGELOG.adoc and add it as part of your PR.

[maximilien]

CHANGELOG.adoc:

* 🧽 Update or clean up current behaviour

Thanks for giving the CHANGELOG some love here, but it would be easier for me (or whoever makes the next release) if you would add this directory to CHANGELOG.adoc and add it as part of your PR.

Not sure I understand this request... I essentially selected that line when submitting the PR. This comes from the template. Am I missing something?

[maximilien]

@navidshaikh and @rhuss can I get a LGTM here. This is done and ready and increases the speed of e2e in appreciable manner. Thx.

[rhuss]

looks good, but please reduce the retry timeout otherwise the situation get even worse wrt/ to e2e duration.

[rhuss]

Not sure I understand this request... I essentially selected that line when submitting the PR. This comes from the template. Am I missing something?

Sorry, didn't state that clearly. Actually I would like to change the template to mention that this line should be directly added into the CHANGELOG.adoc file instead (and add it to the PR files) of just a comment in the PR. Because otherwise still someone need to pick that up and copy it over, which actually is not of much help as one has to go over every PR. At the moment we still have to do it, but for the future it would be really helpful.

No worries here, but I will update the template to add a note.

[rhuss]

@maximilien well, I just saw that this is already mentioned in the template:

<!--
Release Note:

In the following cases, add a short description of PR to the unreleased section in CHANGELOG.adoc:

- 🎁 Add new feature
- 🐛 Fix bug
- 🧽 Update or clean up current behaviour
- 🗑️ Remove feature or internal logic

See other entries in CHANGELOG.adoc as an example.

PLEASE DON'T ADD THAT LINE HERE IN THE PULL-REQUEST DESCRIPTION BUT DIRECTLY IN CHANGELOG.ADOC AND ADD CHANGELOG.ADOC AS PART OF YOUR PULL-REQUEST.
-->

Do you have a suggestion how to state it more clearly ?

[navidshaikh]

I tested the PR locally and works fine.

There are few improvements we can bring to e2e tests setup/teardown in a subsequent PR,
for example: parsing the error while creating the test namespace, if it AlreadyExists,
we can delete and recreate it.

[maximilien]

@maximilien well, I just saw that this is already mentioned in the template:

<!--
Release Note:

In the following cases, add a short description of PR to the unreleased section in CHANGELOG.adoc:

- 🎁 Add new feature
- 🐛 Fix bug
- 🧽 Update or clean up current behaviour
- 🗑️ Remove feature or internal logic

See other entries in CHANGELOG.adoc as an example.

PLEASE DON'T ADD THAT LINE HERE IN THE PULL-REQUEST DESCRIPTION BUT DIRECTLY IN CHANGELOG.ADOC AND ADD CHANGELOG.ADOC AS PART OF YOUR PULL-REQUEST.
-->

Do you have a suggestion how to state it more clearly ?

Ah, OK. Make sense :) Thanks and will update and reduce the inter wait timeout. Cheers 🍻

[rhuss]

Thanks !

/lgtm

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [maximilien,rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment