Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could e2e tests run faster? #598

Closed
maximilien opened this issue Jan 7, 2020 · 2 comments · Fixed by #611
Closed

Could e2e tests run faster? #598

maximilien opened this issue Jan 7, 2020 · 2 comments · Fixed by #611
Labels
kind/question Issue type question

Comments

@maximilien
Copy link
Contributor

In what area(s)?

e2e

Classifications:

/kind good-first-issue
/kind tests

Ask your question here:

Could the e2e tests be faster. There are places for possible easy optimizations.

For instance @navidshaikh has identified a time.Sleep(20 * time.Second) in line of commons.go which perhaps could be reduced or even removed all together?

@MIBc
Copy link
Contributor

MIBc commented Jan 8, 2020

Why does it sleep 20s for creating namespace?

@maximilien
Copy link
Contributor Author

Originally added to ensure that the namespace is created since subsequent tests need the namespace to perform their work. Of course, optimally it should just check that the namespace is created vs waiting.

Let me see if I can add this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Issue type question
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants