Adds option in hack/build.sh to build cross platform binaries #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
size/S
navidshaikh
force-pushed
the
pr/build-cross-platform
branch
from
3e99f15 to
b737c88
Compare
knative-prow-robot
added
size/M
- Use `./hack/build.sh -x` or `./hack/build.sh --build-cross` - Doesn't touch any of the existing flow, providing these options will build binaries and exit
navidshaikh
force-pushed
the
pr/build-cross-platform
branch
from
b737c88 to
1c1f5c5
Compare
knative-prow-robot
added
size/S
I think this has to be in the form |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jimcurtis, maximilien, navidshaikh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
coryrc
pushed a commit
to coryrc/client
that referenced
this pull request
May 14, 2020
Less boilerplate code, more control. Bonuses: * Fixes knative#371.
dsimansk
added a commit
to dsimansk/client
that referenced
this pull request
May 28, 2020
creydr
pushed a commit
to creydr/knative-client
that referenced
this pull request
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
./hack/build.sh -xor./hack/build.sh --build-cross