Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure kn builds cross platform #364

Closed
navidshaikh opened this issue Aug 15, 2019 · 3 comments · Fixed by #385
Closed

Ensure kn builds cross platform #364

navidshaikh opened this issue Aug 15, 2019 · 3 comments · Fixed by #385
Labels
kind/feature New feature or request
Milestone
v0.9.0

Comments

@navidshaikh
Copy link
Collaborator

We should add CI check to ensure kn builds cross platform.
@navidshaikh navidshaikh added the kind/feature New feature or request label Aug 15, 2019
@navidshaikh
Copy link
Collaborator Author

@adrcunha : WDYT ?
We can add this check separately or with existing build-tests.
We also have #371 open in this context to simply invoke ./hack/build.sh -x to ensure this.

@adrcunha
Copy link
Contributor

Unless I'm missing something, I don't see why having yet another separate CI just for build. Invoking build.sh -x as an extra step in the presubmit build tests seem to be simple and good enough to me.

navidshaikh added a commit to navidshaikh/client that referenced this issue Aug 22, 2019
@navidshaikh
Ensures kn cross platform build works in presubmit tests
3759577 
 Fixes knative#364
@navidshaikh navidshaikh mentioned this issue Aug 22, 2019
Closed
navidshaikh added a commit to navidshaikh/client that referenced this issue Aug 22, 2019
@navidshaikh
Ensures kn cross platform build works in presubmit tests
f6c9c6e 
 Fixes knative#364
navidshaikh added a commit to navidshaikh/client that referenced this issue Aug 22, 2019
@navidshaikh
Ensures kn cross platform build works in presubmit tests
35c9183 
 Fixes knative#364
@navidshaikh navidshaikh mentioned this issue Aug 22, 2019
Merged
@navidshaikh
Copy link
Collaborator Author

@adrcunha : Sure, added cross-platform build check after existing pre-submit build tests flow #385, PTAL.

navidshaikh added a commit to navidshaikh/client that referenced this issue Aug 22, 2019
@navidshaikh
Ensures kn cross platform build works in presubmit tests
da58153 
 Fixes knative#364

 - Ensure kn cross platform build works in pre-submit tests
 - Run ./hack/build.sh -x after running existing pre-submit tests
navidshaikh added a commit to navidshaikh/client that referenced this issue Aug 25, 2019
@navidshaikh
Ensures kn cross platform build works in presubmit tests
bf51179 
 Fixes knative#364

 - Ensure kn cross platform build works in pre-submit tests
 - Run ./hack/build.sh -x after running existing pre-submit tests
 - defines a function post_build_tests to invoke cross platform builds
 - post_build_tests will be run by test-infra after build tests are compelete
knative-prow-robot pushed a commit that referenced this issue Aug 26, 2019
@navidshaikh @knative-prow-robot
Ensures kn cross platform build works in presubmit tests (#385)
10f981c 
Fixes #364

 - Ensure kn cross platform build works in pre-submit tests
 - Run ./hack/build.sh -x after running existing pre-submit tests
 - defines a function post_build_tests to invoke cross platform builds
 - post_build_tests will be run by test-infra after build tests are compelete
@navidshaikh navidshaikh added this to the v0.8.0 milestone Aug 27, 2019
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@adrcunha @knative-prow-robot
Create default build/unit test runners. (knative#364)
0fd1d09 
Bonuses:
* lint and link check markdown files in the default build test runner
* explicitly state if tests passed on failed
* add support to custom pre/post build/unit tests
* simplify and expand unit tests for `presubmit-tests.sh`
* also build go code containing build tags in the default build test runner
* update documentation missed in knative#362
dsimansk added a commit to dsimansk/client that referenced this issue Feb 22, 2024
@dsimansk
[release-v1.11] update workflow plugin to 1.32.1 (knative#364)
c9fa146 
* [release-v1.11] update workflow plugin to 1.32.1

* [release-v1.11] pin e2e setup branch to release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
v0.9.0
2 participants
@navidshaikh @adrcunha