[release-1.13] Fixes # Check for Password to Redis on Cloud #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we connect to Redis on Cloud, we generally do not need password and username. We can just be done with TLS.
So with the If check, we need to pass a dummy username and password, which is anyways not valid but the service starts as the server reject the password and goes ahead with TLS connection.
```
apiVersion: sources.knative.dev/v1alpha1
kind: RedisStreamSource
metadata:
name: samplesource
namespace: user1
spec:
address: "rediss://default:password@amaaaaaa74akfsaami2pqxkiosy2gsfsv22fszx77pkb5yj2gemfbqj37lwa-p.redis.us-ashburn-1.oci.oraclecloud.com:6379"
stream: teststream
sink:
ref:
apiVersion: serving.knative.dev/v1
kind: Service
name: event-display
```
knative-prow
bot
added
the
size/XS
|
@pierDipi I'm not sure I fully understand this change, but wouldn't this change be a breaking change to any users on the old version? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, knative-prow-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
knative-prow
bot
merged commit bad4920
into
knative-extensions:release-1.13
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #573