Fixes # Check for Password to Redis on Cloud #573
Conversation
When we connect to Redis on Cloud, we generally do not need password and username. We can just be done with TLS.
So with the If check, we need to pass a dummy username and password, which is anyways not valid but the service starts as the server reject the password and goes ahead with TLS connection.
```
apiVersion: sources.knative.dev/v1alpha1
kind: RedisStreamSource
metadata:
name: samplesource
namespace: user1
spec:
address: "rediss://default:password@amaaaaaa74akfsaami2pqxkiosy2gsfsv22fszx77pkb5yj2gemfbqj37lwa-p.redis.us-ashburn-1.oci.oraclecloud.com:6379"
stream: teststream
sink:
ref:
apiVersion: serving.knative.dev/v1
kind: Service
name: event-display
```
|
Welcome @amarflybot! It looks like this is your first PR to knative-extensions/eventing-redis 🎉 |
knative-prow
bot
added
the
size/XS
knative-prow
bot
added
the
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amarflybot, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
/cherry-pick release-1.14 |
|
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.13 |
|
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@pierDipi: new pull request created: #576 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@pierDipi: new pull request created: #577 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
When we connect to Redis on Cloud, we generally do not need password and username. We can just be done with TLS.
We need to pass a dummy username and password, which is anyways not valid but the service starts as the server reject the password and goes ahead with TLS connection.
Proposed Changes