Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTMLBuilder: use Rouge only when highlighting with Rouge #711

Merged
merged 2 commits into from
Dec 31, 2016
Merged

HTMLBuilder: use Rouge only when highlighting with Rouge #711

merged 2 commits into from
Dec 31, 2016

Conversation

takahashim
Copy link
Collaborator

cf. #710

@takahashim
Copy link
Collaborator Author

LoadErrorはrescueで拾った方がいいんでしょうかね…（でも陽に指定しないと使えないものだし、gem install reviewすればRougeも依存関係でインストールされるはずではあります）

@takahashim
Copy link
Collaborator Author

あー、でもテストが通らないのか。うーむ

@takahashim
Copy link
Collaborator Author

いちおうこれで通るはず、です（OS Xの2.1.5でrougeなしで確認）

@kmuto
Copy link
Owner

kmuto commented Dec 31, 2016

ありがとうございます、よさそうに見えます

@takahashim
Copy link
Collaborator Author

ではmergeします

@takahashim takahashim merged commit f9e79d6 into master Dec 31, 2016
@takahashim takahashim deleted the rouge-delayed-loading branch December 31, 2016 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takahashim @kmuto