Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rougeをロードできなくても泣かないようにしたい #710

Closed
kmuto opened this issue Dec 31, 2016 · 2 comments
Closed

rougeをロードできなくても泣かないようにしたい #710

kmuto opened this issue Dec 31, 2016 · 2 comments

Comments

@kmuto
Copy link
Owner

kmuto commented Dec 31, 2016

htmlutils.rbでrougeをrequireしているため、gemを入れたくない・不要としている環境でも必ず要求されてしまう。
@takahashim
Copy link
Collaborator

むむむ、ちょっと直してみますね

takahashim added a commit that referenced this issue Dec 31, 2016
@takahashim
use rouge only when highlighting with rouge
8c84817 
cf. #710
@takahashim takahashim mentioned this issue Dec 31, 2016
Merged
takahashim added a commit that referenced this issue Dec 31, 2016
@takahashim
HTMLBuilder: use Rouge only when highlighting with Rouge (#711)
f9e79d6 
* use rouge only when highlighting with rouge
    cf. #710
* rescue LoadError when rouge is not installed
@kmuto
Copy link
Owner Author

kmuto commented Dec 31, 2016

ありがとうございます。

@kmuto kmuto closed this as completed Dec 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@takahashim @kmuto