Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove a method Builder#builder_init() #1564

Merged
merged 1 commit into from
Aug 29, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions lib/review/builder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,19 +31,14 @@ def post_paragraph

attr_accessor :doc_status

def initialize(strict = false, *args)
def initialize(strict = false, *_args)
@strict = strict
@output = nil
@logger = ReVIEW.logger
@doc_status = {}
@dictionary = {}
builder_init(*args)
end

def builder_init(*args)
end
private :builder_init

def bind(compiler, chapter, location)
@compiler = compiler
@chapter = chapter
Expand Down
4 changes: 0 additions & 4 deletions lib/review/htmlbuilder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,6 @@ def extname
".#{@book.config['htmlext']}"
end

def builder_init
end
private :builder_init

def builder_init_file
@noindent = nil
@ol_num = nil
Expand Down
4 changes: 0 additions & 4 deletions lib/review/idgxmlbuilder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@ def extname
'.xml'
end

def builder_init
end
private :builder_init

def builder_init_file
@warns = []
@errors = []
Expand Down
3 changes: 2 additions & 1 deletion test/test_review_ext.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ def test_builder_init_on_review_ext
module ReVIEW
class HTMLBuilder
attr_reader :builder_init_test
def builder_init
def initialize(strict = false)
super
@builder_init_test = "test"
end
end
Expand Down