Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove a method Builder#builder_init() #1564

Merged
merged 1 commit into from
Aug 29, 2020
Merged

Conversation

takahashim
Copy link
Collaborator

When you want to do something in *Builder.new, define the method initialize and use super in it.

When you want to do something in `*Builder.new`, define the method `initialize` and use `super` in it.
@takahashim
Copy link
Collaborator Author

@kmuto builder_initがbuilderによって中途半端になっていたので普通にinitialize使うようにするものなのですが、既存のコンテンツに影響ありそうですか?

@kmuto
Copy link
Owner

kmuto commented Aug 29, 2020

私はbuilder_init_fileのほうを使っているので、builder_initのほうはどう料理しても大丈夫です。

@takahashim
Copy link
Collaborator Author

了解です、ではこれでマージします。

builder_init_file の方は、名前が分かりづらいようなので気になってはいるのですが、説明的ではあるし特に変えるほどではないかなあというところです。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants