3.0.11 - V3 patch #268
Closed
3.0.11 - V3 patch #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanleslie
force-pushed
the
3.0.11-patch
branch
from
c8442d7
to
da67133
Compare
Preserving error handling of business logic from the legacy getKlaviyoLists. General exceptions are handled in handleApiResponse method
unsubscribe request body was missing data key, the type keys for both sub/unsub were plural but should be singular, and the retry logic needed to be tweaked. Successful responses can be an empty string so checking for a falsy response value won't work here. We need to explicitly check if response if false in the case that the curl command fails.
siddwarkhedkar
requested changes
Oct 2, 2023
Update changelogger Co-authored-by: Sidd Warkhedkar <[email protected]>
This change was pulled in from the 4.1.0 update but observer logic wasn't introduced until 4.0.0
This is level 10 security risk according to Magento and will not pass its tests
| [Unreleased]: https://github.com/klaviyo/magento2-klaviyo/compare/3.0.11...HEAD | ||
| <!-- END RELEASE NOTES --> | ||
| <!-- BEGIN LINKS --> | ||
| [Unreleased]: https://github.com/klaviyo/magento2-klaviyo/compare/3.1.0...HEAD |
There was a problem hiding this comment.
Suggested change
| [Unreleased]: https://github.com/klaviyo/magento2-klaviyo/compare/3.1.0...HEAD | |
| [Unreleased]: https://github.com/klaviyo/magento2-klaviyo/compare/3.0.11+v3api...HEAD |
siddwarkhedkar
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Patch for klaviyo-magento version 3.0.11.
See #263
Manual Testing Steps
Pre-Submission Checklist:
NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.