4.0.12 - v3 upgrade #263
Merged
4.0.12 - v3 upgrade #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanleslie
force-pushed
the
m2_v3_upgrade
branch
from
db7973d
to
bac8e6d
Compare
jordanleslie
force-pushed
the
m2_v3_upgrade
branch
from
7f6138f
to
44a2f62
Compare
siddwarkhedkar
requested changes
Sep 25, 2023
siddwarkhedkar
force-pushed
the
m2_v3_upgrade
branch
from
0460a02
to
db8d488
Compare
jordanleslie
requested review from
siddwarkhedkar,
smoucka and
cykolln
and removed request for
siddwarkhedkar
This was referenced Sep 26, 2023
Closed
Closed
Closed
ali-aslam
requested changes
Sep 26, 2023
The endpoint is plural profile-subscription-bulk-create-jobs but the type field of the request body is singular. This issue was causing a 400 error
Some endpoints return a 202 and empty string when the response is successful. The retry block was erroneously retrying successful requests
This removes ambiguity between a successfull empty string response and a false response when curl fails
siddwarkhedkar
approved these changes
Sep 29, 2023
ali-aslam
approved these changes
Sep 29, 2023
On successful addition to a profile, the endpoint returns a 204 with an empty response. And otherwise, any errors returned from the call will be handled by the handleAPIresponse method
…nto m2_v3_upgrade
cykolln
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduced a new class,
KlaviyoV3Apidedicated to handling API requests and responses for Klaviyo V3. This class was modeled after @siddwarkhedkar Prestashop V3 PR.This class is responsible for transforming request data to match the structure of the Klaviyo V3 API.
Updated API Endpoint URLs
Updated and centralized the URL endpoints for the Klaviyo V3 API within the KlaviyoV3Api class for consistency.
Added several new exception types tailored to specific error scenarios, improving the precision of error reporting and handling.
New Method handleApiResponse:
Introduced a new method called handleApiResponse in the KlaviyoV3Api class.
This method consistently handles API responses, parsing JSON data, and throwing appropriate exceptions when necessary.
Manual Testing Steps
Pre-Submission Checklist:
NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.