-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ACL for Klaviyo config settings #264
Conversation
@snoop0x7b Thanks for contributing! This won't work as expected because all sections except General use the same
|
@snoop0x7b We are looking to release a new version of the module in December and can include these changes once the feedback above has been addressed. Thanks! |
Thanks! I'll take a look and make those changes! Sorry it took me a while to get to this. |
Thanks for the feedback on this, I have made the requested updates! |
@snoop0x7b Looks good to me. Can you please update the changelog and then I can approve! |
@snoop0x7b We want to get this in the next release so i'm going to go ahead and merge this in and we will update the changelog in a separate PR to reflect. Thanks for contributing! |
Description
This pull request creates the ACL that's raised in this issue #160
It creates permissions for each klaviyo configuration area.
Manual Testing Steps
Pre-Submission Checklist:
NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.