Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACL is missing #160

Closed
mortenbirkelund opened this issue Jan 24, 2022 · 9 comments
Closed

ACL is missing #160

mortenbirkelund opened this issue Jan 24, 2022 · 9 comments

Comments

@mortenbirkelund
Copy link

The module is missing ACL, meaning that only admin users with full access is able to see the module.

@klaviyojad
Copy link
Contributor

@mortenbirkelund thank you for bringing this to our attention. This has been brought up here and is currently in our backlog

@mortenbirkelund
Copy link
Author

Thanks. Do you think this will ever get fixed?

@klaviyojad
Copy link
Contributor

@mortenbirkelund like I said, its in our backlog. Its not really a blocker for many customers just a nice to have.

@kasperth
Copy link

@klaviyojad possible to get status on this?

@JamesFX2
Copy link
Contributor

oh ffs

@JamesFX2
Copy link
Contributor

<?xml version="1.0" ?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Acl/etc/acl.xsd">
    <acl>
        <resources>
            <resource id="Magento_Backend::admin">
                <resource id="Magento_Backend::stores">
                    <resource id="Magento_Backend::stores_settings">
                        <resource id="Magento_Config::config">
                            <resource id="Klaviyo_Reclaim::klaviyo_reclaim_general" title="Klaviyo Configuration" translate="title" sortOrder="150" />
                        </resource>
                    </resource>
                </resource>
            </resource>
        </resources>
    </acl>
</config>

@snoop0x7b
Copy link
Contributor

@mortenbirkelund like I said, its in our backlog. Its not really a blocker for many customers just a nice to have.

PCI does require that you give people the least possible level of permissions to do their job. https://pcidssguide.com/pci-dss-requirement-7/

@cykolln
Copy link
Contributor

cykolln commented Dec 13, 2023

Thanks for the contribution @snoop0x7b! This has been merged and is available in the latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants