Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new methods to KiwiResponses that accept Supplier<Response> #1142

Merged
merged 12 commits into from
Jun 2, 2024
Merged

Add new methods to KiwiResponses that accept Supplier<Response> #1142

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
41ac51d
Add new KiwiResponses#onXxx methods that accept Supplier<Response>
sleberknight May 30, 2024
7bbf9e6
Add shell of javadocs (auto-generated but no contents)
sleberknight May 30, 2024
50265b4
Add tests and TODOs on each new javadoc
sleberknight May 30, 2024
030cd75
Add the javadoc param, return, and throws tags
sleberknight May 30, 2024
8df41b1
Add rest of javadocs for the new onXxx methods, fix a few minor doc e…
sleberknight May 30, 2024
898b5f3
Move WebCallResult and factory below all onXxx methods
sleberknight May 30, 2024
5f51e65
Add argument checking and WARN-level logging when TRACE not enabled
sleberknight Jun 1, 2024
287c863
Add overloads for accept/apply that accept Supplier; code cleanup
sleberknight Jun 2, 2024
c0d3ae2
Update javadocs on accept and apply
sleberknight Jun 2, 2024
9775661
Emphasize that failures/exceptions are ignored in javadocs for onSuccess
sleberknight Jun 2, 2024
70aaf6a
More javadoc improvements
sleberknight Jun 2, 2024
ff5f50e
Code review: Rename all "failedConsumer" to "failureConsumer"
sleberknight Jun 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading