Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new methods to KiwiResponses that accept Supplier<Response> #1142

Merged
merged 12 commits into from
Jun 2, 2024
Merged

Add new methods to KiwiResponses that accept Supplier<Response> #1142

merged 12 commits into from
Jun 2, 2024

Conversation

sleberknight
Copy link
Member

@sleberknight sleberknight commented Jun 2, 2024 •
edited
Loading

  • Add overloaded onXxx, accept, and apply methods which accept a Supplier
  • Where appropriate, some of the new methods add an additional parameter to consume or
    return a value for exceptions thrown by the Supplier

Closes #1141

@sleberknight sleberknight changed the title Add response supplier to on xxx in kiwi responses Add methods to KiwiResponses that accept Response suppliers Jun 2, 2024
@sleberknight sleberknight changed the title Add methods to KiwiResponses that accept Response suppliers Add new methods to KiwiResponses that accept Supplier<Response> Jun 2, 2024
@sleberknight sleberknight self-assigned this Jun 2, 2024
@sleberknight
Emphasize that failures/exceptions are ignored in javadocs for onSuccess
9775661
@sleberknight
More javadoc improvements
70aaf6a 
For the onFailure methods, separate "no action for successful response"
into a new paragraph for clarity.
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sleberknight sleberknight merged commit 342dcc8 into main Jun 2, 2024
5 checks passed
@sleberknight sleberknight deleted the add-response-supplier-to-onXxx-in-KiwiResponses branch June 2, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsingley dsingley dsingley approved these changes

@chrisrohr chrisrohr Awaiting requested review from chrisrohr

Assignees

@sleberknight sleberknight

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add methods to KiwiResponses that accept Response suppliers
2 participants
@sleberknight @dsingley