Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PortAssigner to set more properties from TlsContextConfiguration #404

Merged

Conversation

sleberknight
Copy link
Member

  • PortAssigner should set new property disableSniHostCheck, which was added in kiwi 3.2.0
  • PortAssigner should set additional properties from TlsContextConfiguration: keyStoreType, keyStoreProvider, trustStoreType, trustStoreProvider, jceProvider, certAlias, and supportedCipherSuites
  • Add implNote to javadoc of assignDynamicPorts, which explains that it replaces the HttpsConnectorFactory instances when assigning secure dynamic ports.
  • Add tests to verify the secure properties are correctly set on the HttpsConnectorFactory when using secure dynamic ports
  • Clean up existing tests by using KiwiAssertJ#assertIsExactType, and also by using assertAll when there are a lot of assertions

Closes #398
Closes #401

* PortAssigner should set new property disableSniHostCheck, which
  was added in kiwi 3.2.0
* PortAssigner should set additional properties from
  TlsContextConfiguration: keyStoreType, keyStoreProvider,
  trustStoreType, trustStoreProvider, jceProvider, certAlias,
  and supportedCipherSuites
* Add implNote to javadoc of assignDynamicPorts, which explains
  that it replaces the HttpsConnectorFactory instances when
  assigning secure dynamic ports.
* Add tests to verify the secure properties are correctly set
  on the HttpsConnectorFactory when using secure dynamic ports
* Clean up existing tests by using KiwiAssertJ#assertIsExactType, and
  also by using assertAll when there are a lot of assertions

Closes #398
Closes #401
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sleberknight sleberknight merged commit 491cd15 into master Nov 26, 2023
6 checks passed
@sleberknight sleberknight deleted the 398-401-PortAssigner-set-TLS-properties-on-HttpsConnector branch November 26, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants