Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change PortAssigner to set disableSniHostCheck option on HttpsConnectorFactory #398

Closed
sleberknight opened this issue Nov 22, 2023 · 0 comments · Fixed by #404
Closed

Change PortAssigner to set disableSniHostCheck option on HttpsConnectorFactory #398

sleberknight opened this issue Nov 22, 2023 · 0 comments · Fixed by #404
Assignees
@sleberknight
Labels
enhancement A request for change or improvement to an existing feature
Milestone
3.1.0

Comments

@sleberknight
Copy link
Member

Blocked by kiwiproject/kiwi#1080 and release 3.2.0 of kiwi

In PortAssigner#newHttpsConnectorFactory set the value of disableSniHostCheck on the HttpsConnectorFactory to the corresponding value in TlsContextConfiguration so that SNI host checking can be controlled via configuration.
@sleberknight sleberknight added enhancement A request for change or improvement to an existing feature blocked Blocked by another issue, PR, etc. labels Nov 22, 2023
@sleberknight sleberknight added this to the 3.1.0 milestone Nov 22, 2023
@sleberknight sleberknight self-assigned this Nov 22, 2023
@sleberknight sleberknight mentioned this issue Nov 25, 2023
Closed
@sleberknight sleberknight removed the blocked Blocked by another issue, PR, etc. label Nov 25, 2023
sleberknight added a commit that referenced this issue Nov 25, 2023
@sleberknight
Update PortAssigner to set more properties from TlsContextConfiguration
94d03ab 
* PortAssigner should set new property disableSniHostCheck, which
  was added in kiwi 3.2.0
* PortAssigner should set additional properties from
  TlsContextConfiguration: keyStoreType, keyStoreProvider,
  trustStoreType, trustStoreProvider, jceProvider, certAlias,
  and supportedCipherSuites
* Add implNote to javadoc of assignDynamicPorts, which explains
  that it replaces the HttpsConnectorFactory instances when
  assigning secure dynamic ports.
* Add tests to verify the secure properties are correctly set
  on the HttpsConnectorFactory when using secure dynamic ports
* Clean up existing tests by using KiwiAssertJ#assertIsExactType, and
  also by using assertAll when there are a lot of assertions

Closes #398
Closes #401
@sleberknight sleberknight mentioned this issue Nov 25, 2023
Merged
sleberknight added a commit that referenced this issue Nov 26, 2023
@sleberknight
Update PortAssigner to set more properties from TlsContextConfigurati…
491cd15 
…on (#404)

* PortAssigner should set new property disableSniHostCheck, which
  was added in kiwi 3.2.0
* PortAssigner should set additional properties from
  TlsContextConfiguration: keyStoreType, keyStoreProvider,
  trustStoreType, trustStoreProvider, jceProvider, certAlias,
  and supportedCipherSuites
* Add implNote to javadoc of assignDynamicPorts, which explains
  that it replaces the HttpsConnectorFactory instances when
  assigning secure dynamic ports.
* Add tests to verify the secure properties are correctly set
  on the HttpsConnectorFactory when using secure dynamic ports
* Clean up existing tests by using KiwiAssertJ#assertIsExactType, and
  also by using assertAll when there are a lot of assertions

Closes #398
Closes #401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
enhancement A request for change or improvement to an existing feature
Projects
None yet
Milestone
3.1.0
1 participant
@sleberknight