Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to use UncheckedSQLException instead of ApplicationErrorJdbcException #391

Closed
sleberknight opened this issue Jul 29, 2024 · 0 comments · Fixed by #397
Closed

Migrate to use UncheckedSQLException instead of ApplicationErrorJdbcException #391

sleberknight opened this issue Jul 29, 2024 · 0 comments · Fixed by #397
Assignees
@sleberknight
Labels
refactoring Code refactoring
Milestone
2.2.0

Comments

@sleberknight
Copy link
Member

sleberknight commented Jul 29, 2024 •
edited
Loading

Change code to throw UncheckedSQLException instead of ApplicationErrorJdbcException when the exception thrown was a SQLException.

This is blocked until kiwi 4.2.0 is released.

Also see #390

Any code that uses this and which explicitly caught ApplicationErrorJdbcException will not work as expected anymore. However, we don't expect it to generally be caught directly, i.e., catch (ApplicationErrorJdbcException), so we are not making this a major version change.
@sleberknight sleberknight added refactoring Code refactoring blocked Blocked by another issue, PR, etc. labels Jul 29, 2024
@sleberknight sleberknight mentioned this issue Jul 29, 2024
Closed
@sleberknight sleberknight added this to the 2.1.5 milestone Jul 29, 2024
@sleberknight sleberknight removed the blocked Blocked by another issue, PR, etc. label Aug 4, 2024
@sleberknight sleberknight self-assigned this Aug 4, 2024
sleberknight added a commit that referenced this issue Aug 4, 2024
@sleberknight
Replace ApplicationErrorJdbcException with UncheckedSQLException
fa3a9ea 
Wrap any SQLException that we catch with UncheckedSQLException.

Closes #391
@sleberknight sleberknight mentioned this issue Aug 4, 2024
Merged
sleberknight added a commit that referenced this issue Aug 4, 2024
@sleberknight
Replace ApplicationErrorJdbcException with UncheckedSQLException (#397)
924ad6f 
Wrap any SQLException that we catch with UncheckedSQLException.

Closes #391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleberknight sleberknight

Labels
refactoring Code refactoring
Projects
None yet
Milestone
2.2.0
1 participant
@sleberknight