Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ApplicationErrorJdbcException #392

Closed
sleberknight opened this issue Jul 29, 2024 · 1 comment
Closed

Remove ApplicationErrorJdbcException #392

sleberknight opened this issue Jul 29, 2024 · 1 comment
Labels
API change Change to a public API

Comments

@sleberknight
Copy link
Member

Once we have deprecated ApplicationErrorJdbcException ( #390 ) and refactored the code to use UncheckedSQLException ( #391 ), we can then remove it completely.

This is blocked until kiwi 4.2.0 is released and #390 and #391 are complete.

@sleberknight sleberknight added API change Change to a public API blocked Blocked by another issue, PR, etc. labels Jul 29, 2024
@sleberknight sleberknight modified the milestone: 3.0.0 Jul 29, 2024
@sleberknight
Copy link
Member Author

I am closing this issue because there are several places where we wrap other types of exceptions, for example a Liquibase DatabaseException or CommandExecutionException. If we remove this wrapper exception type, then we would either need to propagate the checked Liquibase exception types, or wrap them in a generic RuntimeException. Since this exception already exists, it's best to just stick with it.

@sleberknight sleberknight closed this as not planned Won't fix, can't repro, duplicate, stale Aug 4, 2024
@sleberknight sleberknight removed the blocked Blocked by another issue, PR, etc. label Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change Change to a public API
Projects
None yet
Development

No branches or pull requests

1 participant