Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyjnius's recipe (mandatory for Python 2.7.11) #778

Closed
wants to merge 3 commits into from

Conversation

opacam
Copy link
Member

@opacam opacam commented Jun 11, 2016

Depends on PR #775 (Python 2.7.11) and PR #793

@brussee
Copy link
Contributor

brussee commented Jun 15, 2016

I see you are copying code on various recipes to set the right include and link paths that obviously only work for python 2.7 while the recipe also accepts python 3.5 from crystax.

    def get_recipe_env(self, arch=None):
        env = super(PyjniusRecipe, self).get_recipe_env(arch)
        env['PYTHON_ROOT'] = self.ctx.get_python_install_dir()
        env['CFLAGS'] += ' -I' + env['PYTHON_ROOT'] + '/include/python2.7'
        env['LDFLAGS'] += ' -L' + env['PYTHON_ROOT'] + '/lib' + \
                          ' -lpython2.7'

Issues #668 and #669 point out the reason why I added this to my recipes, but I consider this a workaround and not good practice.

@opacam
Copy link
Member Author

opacam commented Jun 16, 2016

A quick look at the affected recipes make me notice that all of them has the variable "call_hostpython_via_targetpython" set to False... so I guess, that modifying The function "PythonRecipe.get_recipe_env" (with an "if else" for python2), will make it work for all of them (and some others that has not been tested by me, or you)... I will make some tests with this when I have enough time...this will simplify things for all the recipes you mention and, possibly, for other recipes not tested

Thanks for letting me notice !!!

…nto pyjnius-python-base

# Solved Conflicts: pythonforandroid/recipes/pyjnius/__init__.py
@opacam
Copy link
Member Author

opacam commented Aug 12, 2016

¡¡¡ Closed because currently I'm working with python's version 2.7.12,
and this recipe isn't needed anymore !!!

@opacam opacam closed this Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants