Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDFlags missing ' -lpython2.7' #668

Closed
brussee opened this issue Mar 4, 2016 · 2 comments
Closed

LDFlags missing ' -lpython2.7' #668

brussee opened this issue Mar 4, 2016 · 2 comments

Comments

@brussee
Copy link
Contributor

brussee commented Mar 4, 2016

In case of the PyLevelDB recipe if I comment this line:

env['LDFLAGS'] += ' -lpython2.7'

it breaks on runtime with this error:

I/python(24256): ImportError: dlopen failed: cannot locate symbol "_Py_NoneStruct" referenced by "/data/data/org.tribler.android/files/lib/python2.7/site-packages/leveldb.so"...

It somehow is not added automatically apparently...

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@inclement
Copy link
Member

From a quick check, it looks like none of the recipe classes automatically add this (although I thought they did) - does that look the same to you? I don't think there's a reason not to link it automatically in the compiled ones, so if that's right then let's add it in their get_recipe_env.

@AndreMiras
Copy link
Member

Yes I also noticed python linking flags seem to be missing in parent recipes.
As of today I only see it in CppCompiledComponentsPythonRecipe.get_recipe_env() and CythonRecipe.get_recipe_env().
This pull request seems to tacle part of it #793.

I think it would greatly improve code base quality and recipes reliability to tackle that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants