Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements: relax version bound on "pep517" #2680

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

SomberNight
Copy link
Contributor

The "<0.7.0" bound was added in 9f6d6fc to fix #1994 :

The TestGetSystemPythonExecutable.test_virtualenv and TestGetSystemPythonExecutable.test_venv tests started failing all of a sudden. Error was:

ModuleNotFoundError: No module named \'pytoml\'\n'

This ca be reproduced in local via:

pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv

I think this no longer applies,
$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable runs successfully for me, using latest pep517==0.13.0.


Also, let's see if the CI tests pass.

The "<0.7.0" bound was added in kivy@9f6d6fc
to fix kivy#1994 :

> The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was:
>
> ```
> ModuleNotFoundError: No module named \'pytoml\'\n'
> ```
>
> This ca be reproduced in local via:
>
> ```shell
> pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv
> ```

I think this no longer applies,
`$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable`
runs successfully for me, using latest `pep517==0.13.0`.
@misl6
Copy link
Member

misl6 commented Oct 5, 2022

Fixes #2573

@misl6 misl6 linked an issue Oct 5, 2022 that may be closed by this pull request
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for the CI to complete, but LGTM.
Thank you!

@misl6 misl6 merged commit 25f3a53 into kivy:develop Oct 6, 2022
SomberNight added a commit to SomberNight/python-for-android that referenced this pull request Oct 10, 2022
The "<0.7.0" bound was added in kivy@9f6d6fc
to fix kivy#1994 :

> The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was:
>
> ```
> ModuleNotFoundError: No module named \'pytoml\'\n'
> ```
>
> This ca be reproduced in local via:
>
> ```shell
> pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv
> ```

I think this no longer applies,
`$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable`
runs successfully for me, using latest `pep517==0.13.0`.
SomberNight added a commit to SomberNight/python-for-android that referenced this pull request Oct 14, 2022
The "<0.7.0" bound was added in kivy@9f6d6fc
to fix kivy#1994 :

> The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was:
>
> ```
> ModuleNotFoundError: No module named \'pytoml\'\n'
> ```
>
> This ca be reproduced in local via:
>
> ```shell
> pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv
> ```

I think this no longer applies,
`$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable`
runs successfully for me, using latest `pep517==0.13.0`.
accumulator pushed a commit to accumulator/python-for-android that referenced this pull request Oct 18, 2022
The "<0.7.0" bound was added in kivy@9f6d6fc
to fix kivy#1994 :

> The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was:
>
> ```
> ModuleNotFoundError: No module named \'pytoml\'\n'
> ```
>
> This ca be reproduced in local via:
>
> ```shell
> pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv
> ```

I think this no longer applies,
`$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable`
runs successfully for me, using latest `pep517==0.13.0`.
accumulator pushed a commit to accumulator/python-for-android that referenced this pull request Jan 5, 2023
The "<0.7.0" bound was added in kivy@9f6d6fc
to fix kivy#1994 :

> The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was:
>
> ```
> ModuleNotFoundError: No module named \'pytoml\'\n'
> ```
>
> This ca be reproduced in local via:
>
> ```shell
> pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv
> ```

I think this no longer applies,
`$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable`
runs successfully for me, using latest `pep517==0.13.0`.
accumulator pushed a commit to accumulator/python-for-android that referenced this pull request Jan 5, 2023
The "<0.7.0" bound was added in kivy@9f6d6fc
to fix kivy#1994 :

> The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was:
>
> ```
> ModuleNotFoundError: No module named \'pytoml\'\n'
> ```
>
> This ca be reproduced in local via:
>
> ```shell
> pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv
> ```

I think this no longer applies,
`$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable`
runs successfully for me, using latest `pep517==0.13.0`.
accumulator pushed a commit to accumulator/python-for-android that referenced this pull request Jan 6, 2023
The "<0.7.0" bound was added in kivy@9f6d6fc
to fix kivy#1994 :

> The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was:
>
> ```
> ModuleNotFoundError: No module named \'pytoml\'\n'
> ```
>
> This ca be reproduced in local via:
>
> ```shell
> pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv
> ```

I think this no longer applies,
`$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable`
runs successfully for me, using latest `pep517==0.13.0`.
shyamnathp pushed a commit to shyamnathp/python-for-android that referenced this pull request Feb 17, 2023
The "<0.7.0" bound was added in kivy@9f6d6fc
to fix kivy#1994 :

> The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was:
>
> ```
> ModuleNotFoundError: No module named \'pytoml\'\n'
> ```
>
> This ca be reproduced in local via:
>
> ```shell
> pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv
> ```

I think this no longer applies,
`$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable`
runs successfully for me, using latest `pep517==0.13.0`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants