Skip to content

Commit

Permalink
requirements: relax version bound on "pep517" (kivy#2680)
Browse files Browse the repository at this point in the history
The "<0.7.0" bound was added in kivy@9f6d6fc
to fix kivy#1994 :

> The `TestGetSystemPythonExecutable.test_virtualenv` and `TestGetSystemPythonExecutable.test_venv` tests started failing all of a sudden. Error was:
>
> ```
> ModuleNotFoundError: No module named \'pytoml\'\n'
> ```
>
> This ca be reproduced in local via:
>
> ```shell
> pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable::test_virtualenv
> ```

I think this no longer applies,
`$ pytest tests/test_pythonpackage_basic.py::TestGetSystemPythonExecutable`
runs successfully for me, using latest `pep517==0.13.0`.
  • Loading branch information
SomberNight committed Oct 14, 2022
1 parent a2fb7c8 commit e94152f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
install_reqs = [
'appdirs', 'colorama>=0.3.3', 'jinja2',
'sh>=1.10; sys_platform!="nt"',
'pep517<0.7.0', 'toml',
'pep517', 'toml',
]
# (pep517 and toml are used by pythonpackage.py)

Expand Down
2 changes: 1 addition & 1 deletion tests/test_pythonpackage_basic.py
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ def test_venv(self):
])
subprocess.check_output([
os.path.join(test_dir, "venv", "bin", "pip"),
"install", "-U", "pep517<0.7.0"
"install", "-U", "pep517"
])
subprocess.check_output([
os.path.join(test_dir, "venv", "bin", "pip"),
Expand Down

0 comments on commit e94152f

Please sign in to comment.