android: add support for adaptive icon/launcher #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive This adds a `--icon-fg` and a `--icon-bg` build option to the sdl2 bootstrap, that can be used to specify two PNG files to be used as the foreground and background of an adaptive icon. These will get used if API 26+ is available at runtime. The existing `--icon` option to specify an icon as a single PNG file is kept, as - this provides backwards compatibility, - and even if the new options are used, it might be a good idea to set all three options: when running on API <26, the PNG specified via `--icon` gets used.
SomberNight
added a commit
to SomberNight/electrum
that referenced
this pull request
Apr 7, 2021
see https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive p4a and buildozer had to be patched for this; I will try to upstream the patches, see: kivy/python-for-android#2446 kivy/buildozer#1312
SomberNight
added a commit
to SomberNight/electrum
that referenced
this pull request
Apr 8, 2021
see https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive p4a and buildozer had to be patched for this; I will try to upstream the patches, see: kivy/python-for-android#2446 kivy/buildozer#1312
tshirtman
approved these changes
Jun 14, 2021
|
Thanks! |
rnixx
added a commit
to rnixx/python-for-android
that referenced
this pull request
Jun 16, 2021
…con will fail in build.py as of the changes in kivy#2446
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive
This adds a
--icon-fgand a--icon-bgbuild option to the sdl2 bootstrap,that can be used to specify two PNG files to be used as the foreground and background
of an adaptive icon. These will get used if API 26+ is available at runtime.
The existing
--iconoption to specify an icon as a single PNG file is kept, asoptions: when running on API <26, the PNG specified via
--icongets used.