android: adaptive icon/launcher: expose p4a options in buildozer.spec #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SomberNight
added a commit
to SomberNight/electrum
that referenced
this pull request
Apr 7, 2021
see https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive p4a and buildozer had to be patched for this; I will try to upstream the patches, see: kivy/python-for-android#2446 kivy/buildozer#1312
SomberNight
added a commit
to SomberNight/electrum
that referenced
this pull request
Apr 8, 2021
see https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive p4a and buildozer had to be patched for this; I will try to upstream the patches, see: kivy/python-for-android#2446 kivy/buildozer#1312
tshirtman
previously approved these changes
May 2, 2021
SomberNight
force-pushed
the
202104_android_adaptiveicon
branch
from
0ce292f
to
409459e
Compare
I've added the option to |
|
yeah, i don’t know if there is something similar for IOS we need to support, but that should be fine for now, thanks! |
tshirtman
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see related p4a PR: kivy/python-for-android#2446
This exposes the p4a options added in the referenced PR in
buildozer.spec.