fix: google password manager breaks KeyboardAwareScrollView
#667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillzyusko
added
🐛 bug
📊 Package size report
|
kirillzyusko
deleted the
fix/google-password-manager-breaks-keyboard-aware-scroll-view
branch
2 tasks
kirillzyusko
added a commit
that referenced
this pull request
Nov 26, 2024
…errupted (#704) ## 📜 Description Fixed broken `KeyboardStickyView` position if keyboard dismissing has been interrupted (by showing a native sheet, for example). ## 💡 Motivation and Context This problem was discovered in bluesky-social/social-app#6739 However I discovered such issue even earlier in #667 - there I found out that progress can be interrupted (keyboard can start its movement, but then will be interrupted and will be instantly hidden) and `onEnd` event will be triggered. Back to the times I fixed a problem by calling `maybeScroll` in `onEnd` handler. in this PR I want to do a similar thing - the only difference is that I want to add `onEnd` event to mapping for Animated/Reanimated values (`useKeyboardAnimation`/`useReanimatedKeyboardAnimation` hooks). A proper fix for bluesky-social/social-app#6739 ## 📢 Changelog ### Android - update `SharedValue` for `end` event on Android; - update `Animated.Value` for `end` event on iOS; ## 🤔 How Has This Been Tested? Tested on CI. ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixed input hiding when google password manager pops up.
💡 Motivation and Context
The native code worked correctly, however when Google Password manager popup appears, then we have next events:
So because of this fact we kept bottom area (fake view). When keyboard appear again, then we were animating this bottom view again from 0 to 290. But since in the beginning of the keyboard movement focused input was above the keyboard - we don't perform
scrollTooperation. But when bottom padding collapses to0an then input moves behind the keyboard. And since we don't callscrollToit keeps its present there.To fix the problem and don't break the state machine we need to synchronize keyboardFrame (currentKeybaordFrame) in
onEndhandler. Thus when popup appears, the input will be moved to bottom. When keyboard appear it'll correctly understand, that the keyboard will overlap the input and thus it will push the input as expected.Fixes #665
📢 Changelog
JS
currentKeyboardFrameinonEndhandler;syncKeyboardFramefunction.🤔 How Has This Been Tested?
Tested manually on Pixel 7 Pro API 35.
📸 Screenshots (if appropriate):
telegram-cloud-document-2-5263016610569936569.mp4
telegram-cloud-document-2-5263016610569936563.mp4
📝 Checklist