Fix Android keyboard bug when opening a sheet #6739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozzius
changed the title
|
what’s the bug upstream? is there something we can contribute? |
2 tasks
|
@mozzius thanks! I prepared a fix in repository: kirillzyusko/react-native-keyboard-controller#704 Would you mind to try to test it? 👀 |
|
Confirmed that that patch fixes the issue, however actually I think we want to go with this approach - |
gaearon
approved these changes
Nov 26, 2024
mozzius
force-pushed
the
samuel/dms-keyboard-bug-2
branch
from
fc26529 to
1de6a1c
Compare
arcalinea
temporarily deployed
to
samuel/dms-keyboard-bug-2 - social-app PR #6739
Render
Destroyed
kirillzyusko
added a commit
to kirillzyusko/react-native-keyboard-controller
that referenced
this pull request
Nov 26, 2024
…errupted (#704) ## 📜 Description Fixed broken `KeyboardStickyView` position if keyboard dismissing has been interrupted (by showing a native sheet, for example). ## 💡 Motivation and Context This problem was discovered in bluesky-social/social-app#6739 However I discovered such issue even earlier in #667 - there I found out that progress can be interrupted (keyboard can start its movement, but then will be interrupted and will be instantly hidden) and `onEnd` event will be triggered. Back to the times I fixed a problem by calling `maybeScroll` in `onEnd` handler. in this PR I want to do a similar thing - the only difference is that I want to add `onEnd` event to mapping for Animated/Reanimated values (`useKeyboardAnimation`/`useReanimatedKeyboardAnimation` hooks). A proper fix for bluesky-social/social-app#6739 ## 📢 Changelog ### Android - update `SharedValue` for `end` event on Android; - update `Animated.Value` for `end` event on iOS; ## 🤔 How Has This Been Tested? Tested on CI. ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android, opening a menu in DMs would cause the keyboard input to enter a strange state. This attempts to fix it by setting the keyboard height on the
onEndevent and reimplementing KeyboardStickyView manually (turns out it's a very simple component, and we basically are already doing same the logic anyway for the scrollview)Before
Screen.Recording.2024-11-26.at.00.17.09.mov
After
Screen.Recording.2024-11-26.at.00.18.39.mov