Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HCP EP2024 #13

Merged
merged 33 commits into from
Apr 26, 2024
Merged

HCP EP2024 #13

merged 33 commits into from
Apr 26, 2024

Conversation

chrismostert
Copy link
Contributor

Main changes

  • Implemented check for potentially switched candidates
    • Added votes per candidate to the parsed data
    • Added neighbourhood data to be able to compare polling stations at a lower regional level (by using zip code in the EML)
    • Implemented check according to the cbs report
  • Changed threshold values for new version of 'controleprotocol', where we check the difference between admitted voters and cast votes based on both the absolute value and the percentage
  • Added additional test cases for new functionality and to make sure that the new Na31-1 and Na31-2 are compatible
  • Implemented a textual summary for each row in the output for TopDesk import

@chrismostert
Change difference calculation according to new protocol
6631004
@chrismostert
Make CSV threshold values dynamic
88ba467
@chrismostert
Add candidate votes to EML class
3e8e56f
@chrismostert
Implement switched candidates check at municipality level
1eedc7f
@chrismostert
Allow passing neighbourhood data and save zip in EmlMetadata
3a7263b
@chrismostert
Add function for getting reference group based on neighbourhood data …
3d415a4 
…(if available)
@chrismostert
Implement potentially switched candidates for neighbourhoods
b2c3142
@chrismostert
Properly handle invalid zip codes
ba444fe
@chrismostert
Add unit test for switched candidate protocol_check
7393a46
@chrismostert
Add test cases for neighbourhood functions
bb0720c
@chrismostert
Don't add temporary/mobile polling stations to reporting neighbourhood
4884f15
@chrismostert
Add switched candidates to csv writer
08fd6a7
@chrismostert
Write switched candidate only if not excluded by neighbourhood check
3bafb0b
@chrismostert
Pass reference group size for neighbourhood check
8067ec1
@chrismostert
Move some of the logic to protocol_checks
ce56285
@chrismostert
Additional test for combining switched candidates at municipality and…
f55d2cd 
… neighbourhood level
@chrismostert
Minor refactoring for switched candidates check
44de198 
- Moved all checking logic to protocol_checks instead of eml class
- Made the switched candidate check one 'public' function with name which corresponds with other checks (prefix check_) and made all other helper functions 'private', i.e. with prefix _get
@chrismostert
Added some more test cases for 'public' facing switched candidate check
0b5626b
@chrismostert
Move constructing reference groups
85b7c33 
It is more pure to just hand the data, which is loaded in main, to the run_protocol function instead of doing the preprocessing in main
@chrismostert
Update readme
eb44687
@chrismostert
Add docstring documentation
61fca69
@chrismostert
Add election ID as identifying column
8ffbd03
@chrismostert
Add summarise function for topdesk import
30bcdfb
@chrismostert
Add summary to CSV output for topdesk import
e6b74ac
@chrismostert
Only write csv A if not already recounted. Always write CSV B
b8becff
@chrismostert
Format reporting unit name to exclude zip code and prefix
03db6c7
@chrismostert
Add additional e2e testcases
207d6c1
@chrismostert
Add odt test cases for EP2024
cdcbc8d
@chrismostert
Simply summary sentence structure
d996fcc
@chrismostert
Don't floor output values but round to one digit
4e334dd
@praseodym praseodym self-requested a review April 25, 2024 11:34
@chrismostert
Explicitly indicate that eml files are testdata
f2863c7 
This is to prevent potential confusion
@chrismostert chrismostert merged commit 7348582 into master Apr 26, 2024
1 check passed
@chrismostert chrismostert deleted the EP2024 branch April 29, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praseodym praseodym praseodym left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrismostert @praseodym