Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCP EP2024 #13

Merged
merged 33 commits into from
Apr 26, 2024
Merged

HCP EP2024 #13

merged 33 commits into from
Apr 26, 2024

Commits on Feb 12, 2024

  1. Change difference calculation according to new protocol

    @chrismostert
    chrismostert committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    6631004 View commit details
    Browse the repository at this point in the history

  2. Make CSV threshold values dynamic

    @chrismostert
    chrismostert committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    88ba467 View commit details
    Browse the repository at this point in the history

  3. Add candidate votes to EML class

    @chrismostert
    chrismostert committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    3e8e56f View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Implement switched candidates check at municipality level

    @chrismostert
    chrismostert committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    1eedc7f View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Allow passing neighbourhood data and save zip in EmlMetadata

    @chrismostert
    chrismostert committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    3a7263b View commit details
    Browse the repository at this point in the history

  2. Add function for getting reference group based on neighbourhood data … 

    …(if available)
    @chrismostert
    chrismostert committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    3d415a4 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Implement potentially switched candidates for neighbourhoods

    @chrismostert
    chrismostert committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    b2c3142 View commit details
    Browse the repository at this point in the history

  2. Properly handle invalid zip codes

    @chrismostert
    chrismostert committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    ba444fe View commit details
    Browse the repository at this point in the history

  3. Add unit test for switched candidate protocol_check

    @chrismostert
    chrismostert committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    7393a46 View commit details
    Browse the repository at this point in the history

  4. Add test cases for neighbourhood functions

    @chrismostert
    chrismostert committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    bb0720c View commit details
    Browse the repository at this point in the history

  5. Don't add temporary/mobile polling stations to reporting neighbourhood

    @chrismostert
    chrismostert committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    4884f15 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Add switched candidates to csv writer

    @chrismostert
    chrismostert committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    08fd6a7 View commit details
    Browse the repository at this point in the history

  2. Write switched candidate only if not excluded by neighbourhood check

    @chrismostert
    chrismostert committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    3bafb0b View commit details
    Browse the repository at this point in the history

  3. Pass reference group size for neighbourhood check

    @chrismostert
    chrismostert committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    8067ec1 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Move some of the logic to protocol_checks

    @chrismostert
    chrismostert committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    ce56285 View commit details
    Browse the repository at this point in the history

  2. Additional test for combining switched candidates at municipality and… 

    … neighbourhood level
    @chrismostert
    chrismostert committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    f55d2cd View commit details
    Browse the repository at this point in the history

  3. Minor refactoring for switched candidates check 

    - Moved all checking logic to protocol_checks instead of eml class
- Made the switched candidate check one 'public' function with name which corresponds with other checks (prefix check_) and made all other helper functions 'private', i.e. with prefix _get
    @chrismostert
    chrismostert committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    44de198 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Added some more test cases for 'public' facing switched candidate check

    @chrismostert
    chrismostert committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    0b5626b View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Move constructing reference groups 

    It is more pure to just hand the data, which is loaded in main, to the run_protocol function instead of doing the preprocessing in main
    @chrismostert
    chrismostert committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    85b7c33 View commit details
    Browse the repository at this point in the history

  2. Update readme

    @chrismostert
    chrismostert committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    eb44687 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Add docstring documentation

    @chrismostert
    chrismostert committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    61fca69 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Add election ID as identifying column

    @chrismostert
    chrismostert committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    8ffbd03 View commit details
    Browse the repository at this point in the history

  2. Add summarise function for topdesk import

    @chrismostert
    chrismostert committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    30bcdfb View commit details
    Browse the repository at this point in the history

  3. Add summary to CSV output for topdesk import

    @chrismostert
    chrismostert committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    e6b74ac View commit details
    Browse the repository at this point in the history

  4. Only write csv A if not already recounted. Always write CSV B

    @chrismostert
    chrismostert committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    b8becff View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Format reporting unit name to exclude zip code and prefix

    @chrismostert
    chrismostert committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    03db6c7 View commit details
    Browse the repository at this point in the history

  2. Add additional e2e testcases

    @chrismostert
    chrismostert committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    207d6c1 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Add odt test cases for EP2024

    @chrismostert
    chrismostert committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    cdcbc8d View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Simply summary sentence structure

    @chrismostert
    chrismostert committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    d996fcc View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Don't floor output values but round to one digit

    @chrismostert
    chrismostert committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    4e334dd View commit details
    Browse the repository at this point in the history

  2. Change output text for topdesk import 

    Makes sure that the text is non-ambiguous
    @chrismostert
    chrismostert committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    7d39790 View commit details
    Browse the repository at this point in the history

  3. Handle edge cases where zipcode is supplied without a space

    @chrismostert
    chrismostert committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    cc91e5a View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Explicitly indicate that eml files are testdata 

    This is to prevent potential confusion
    @chrismostert
    chrismostert committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    f2863c7 View commit details
    Browse the repository at this point in the history