[Infra] Use callback for logger.trace calls (elastic#199805)

Use a callback for logger.trace() so big objects only get stringified when trace logging is enabled. --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit b8e6bbd)
kibanamachine · Nov 19, 2024 · cf8f08a · cf8f08a
1 parent f3f9ac9
commit cf8f08a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/...servability_solution/infra/server/lib/alerting/inventory_metric_threshold/lib/get_data.ts b/...servability_solution/infra/server/lib/alerting/inventory_metric_threshold/lib/get_data.ts
@@ -159,9 +159,9 @@ export const getData = async (
     customMetric,
     fieldsExisted
   );
-  logger.trace(`Request: ${JSON.stringify(request)}`);
+  logger.trace(() => `Request: ${JSON.stringify(request)}`);
   const body = await esClient.search<undefined, ResponseAggregations>(request);
-  logger.trace(`Response: ${JSON.stringify(body)}`);
+  logger.trace(() => `Response: ${JSON.stringify(body)}`);
   if (body.aggregations) {
     return handleResponse(body.aggregations, previousNodes);
   }

diff --git a/...ervability_solution/infra/server/lib/alerting/metric_threshold/lib/check_missing_group.ts b/...ervability_solution/infra/server/lib/alerting/metric_threshold/lib/check_missing_group.ts
@@ -57,9 +57,9 @@ export const checkMissingGroups = async (
     ];
   });
 
-  logger.trace(`Request: ${JSON.stringify({ searches })}`);
+  logger.trace(() => `Request: ${JSON.stringify({ searches })}`);
   const response = await esClient.msearch({ searches });
-  logger.trace(`Response: ${JSON.stringify(response)}`);
+  logger.trace(() => `Response: ${JSON.stringify(response)}`);
 
   const verifiedMissingGroups = response.responses
     .map((resp, index) => {

diff --git a/...plugins/observability_solution/infra/server/lib/alerting/metric_threshold/lib/get_data.ts b/...plugins/observability_solution/infra/server/lib/alerting/metric_threshold/lib/get_data.ts
@@ -277,10 +277,10 @@ export const getData = async (
       fieldsExisted
     ),
   };
-  logger.trace(`Request: ${JSON.stringify(request)}`);
+  logger.trace(() => `Request: ${JSON.stringify(request)}`);
   const body = await esClient.search<undefined, ResponseAggregations>(request);
   const { aggregations, _shards } = body;
-  logger.trace(`Response: ${JSON.stringify(body)}`);
+  logger.trace(() => `Response: ${JSON.stringify(body)}`);
   if (aggregations) {
     return handleResponse(aggregations, previousResults, _shards.successful);
   } else if (_shards.successful) {