Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra] Use callback for logger.trace calls #199805

Merged
merged 4 commits into from
Nov 19, 2024
Merged

[Infra] Use callback for logger.trace calls #199805

merged 4 commits into from
Nov 19, 2024

Conversation

dgieselaar
Copy link
Member

@dgieselaar dgieselaar commented Nov 12, 2024 •
edited by kibanamachine
Loading

Use a callback for logger.trace() so big objects only get stringified when trace logging is enabled.

@dgieselaar dgieselaar added v9.0.0 backport:prev-major Backport to (8.x, 8.17, 8.16, 8.15) the previous major branch and other branches in development v8.17.0 labels Nov 12, 2024
@dgieselaar dgieselaar requested a review from a team as a code owner November 12, 2024 14:43
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

dominiqueclarke
dominiqueclarke approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgieselaar dgieselaar added the release_note:skip Skip the PR/issue when compiling release notes label Nov 14, 2024
@dgieselaar
Copy link
Member Author

@elasticmachine merge upstream

@dgieselaar
Copy link
Member Author

@elasticmachine merge upstream

@dgieselaar dgieselaar enabled auto-merge (squash) November 19, 2024 07:02
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 19, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 4bcf7db
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-199805-4bcf7dbcf3cf

Metrics [docs]

✅ unchanged

History

@dgieselaar dgieselaar merged commit b8e6bbd into elastic:main Nov 19, 2024
25 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11909417661

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 19, 2024
@dgieselaar
[Infra] Use callback for logger.trace calls (elastic#199805)
7fe617f 
Use a callback for logger.trace() so big objects only get stringified
when trace logging is enabled.

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit b8e6bbd)
@kibanamachine kibanamachine mentioned this pull request Nov 19, 2024
Closed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 19, 2024
@dgieselaar
[Infra] Use callback for logger.trace calls (elastic#199805)
cf8f08a 
Use a callback for logger.trace() so big objects only get stringified
when trace logging is enabled.

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit b8e6bbd)
@kibanamachine kibanamachine mentioned this pull request Nov 19, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 19, 2024
@dgieselaar
[Infra] Use callback for logger.trace calls (elastic#199805)
1b37274 
Use a callback for logger.trace() so big objects only get stringified
when trace logging is enabled.

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit b8e6bbd)
@kibanamachine kibanamachine mentioned this pull request Nov 19, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.15
✅ 8.16
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Nov 19, 2024
Merged
2 tasks
kibanamachine added a commit that referenced this pull request Nov 19, 2024
@kibanamachine @dgieselaar
[8.x] [Infra] Use callback for logger.trace calls (#199805) (#200684)
99e3f67 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Infra] Use callback for logger.trace calls
(#199805)](#199805)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dario
Gieselaar","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-19T08:51:55Z","message":"[Infra]
Use callback for logger.trace calls (#199805)\n\nUse a callback for
logger.trace() so big objects only get stringified\r\nwhen trace logging
is enabled.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"b8e6bbd4610b50169f1d19a0929d0db68aa82ad7","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","v8.17.0"],"title":"[Infra]
Use callback for logger.trace
calls","number":199805,"url":"https://github.com/elastic/kibana/pull/199805","mergeCommit":{"message":"[Infra]
Use callback for logger.trace calls (#199805)\n\nUse a callback for
logger.trace() so big objects only get stringified\r\nwhen trace logging
is enabled.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"b8e6bbd4610b50169f1d19a0929d0db68aa82ad7"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199805","number":199805,"mergeCommit":{"message":"[Infra]
Use callback for logger.trace calls (#199805)\n\nUse a callback for
logger.trace() so big objects only get stringified\r\nwhen trace logging
is enabled.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"b8e6bbd4610b50169f1d19a0929d0db68aa82ad7"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dario Gieselaar <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 19, 2024
@kibanamachine @dgieselaar
[8.16] [Infra] Use callback for logger.trace calls (#199805) (#200683)
44bfa2d 
# Backport

This will backport the following commits from `main` to `8.16`:
- [[Infra] Use callback for logger.trace calls
(#199805)](#199805)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dario
Gieselaar","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-19T08:51:55Z","message":"[Infra]
Use callback for logger.trace calls (#199805)\n\nUse a callback for
logger.trace() so big objects only get stringified\r\nwhen trace logging
is enabled.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"b8e6bbd4610b50169f1d19a0929d0db68aa82ad7","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","v8.17.0"],"title":"[Infra]
Use callback for logger.trace
calls","number":199805,"url":"https://github.com/elastic/kibana/pull/199805","mergeCommit":{"message":"[Infra]
Use callback for logger.trace calls (#199805)\n\nUse a callback for
logger.trace() so big objects only get stringified\r\nwhen trace logging
is enabled.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"b8e6bbd4610b50169f1d19a0929d0db68aa82ad7"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199805","number":199805,"mergeCommit":{"message":"[Infra]
Use callback for logger.trace calls (#199805)\n\nUse a callback for
logger.trace() so big objects only get stringified\r\nwhen trace logging
is enabled.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"b8e6bbd4610b50169f1d19a0929d0db68aa82ad7"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dario Gieselaar <[email protected]>
@kibanamachine kibanamachine added v8.16.1 backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 19, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@dgieselaar dgieselaar removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:prev-major Backport to (8.x, 8.17, 8.16, 8.15) the previous major branch and other branches in development labels Nov 21, 2024
@dgieselaar dgieselaar deleted the trace-logs-with-callback branch November 21, 2024 11:54
@mistic
Copy link
Member

mistic commented Nov 21, 2024

This PR didn't make it into the latest BC of v8.16.1. Updating the labels.

@mistic mistic added v8.16.2 and removed v8.16.1 labels Nov 21, 2024
@maryam-saeidi maryam-saeidi mentioned this pull request Nov 25, 2024
Closed
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@dgieselaar @elasticmachine
@kibanamachine @CAWilson94
[Infra] Use callback for logger.trace calls (elastic#199805)
7c4e25e 
Use a callback for logger.trace() so big objects only get stringified
when trace logging is enabled.

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees
No one assigned
Labels
ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.16.2 v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dgieselaar @elasticmachine @kibanamachine @mistic @dominiqueclarke