[ML] Adds waiting state for transforms. (elastic#98592)

When no transform nodes are available, existing continuous transform end up in a waiting state. This PR adds support for this state in the transforms UI. Without the fix, transforms in a waiting state would fail to show up in the transform list.
kibanamachine · Apr 29, 2021 · 765c8c7 · 765c8c7
1 parent 3ac08ba
commit 765c8c7
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/x-pack/plugins/transform/common/api_schemas/common.ts b/x-pack/plugins/transform/common/api_schemas/common.ts
@@ -17,13 +17,15 @@ export const transformIdsSchema = schema.arrayOf(
 
 export type TransformIdsSchema = TypeOf<typeof transformIdsSchema>;
 
+// reflects https://github.com/elastic/elasticsearch/blob/master/x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/transform/transforms/TransformStats.java#L250
 export const transformStateSchema = schema.oneOf([
   schema.literal(TRANSFORM_STATE.ABORTING),
   schema.literal(TRANSFORM_STATE.FAILED),
   schema.literal(TRANSFORM_STATE.INDEXING),
   schema.literal(TRANSFORM_STATE.STARTED),
   schema.literal(TRANSFORM_STATE.STOPPED),
   schema.literal(TRANSFORM_STATE.STOPPING),
+  schema.literal(TRANSFORM_STATE.WAITING),
 ]);
 
 export const indexPatternTitleSchema = schema.object({

diff --git a/x-pack/plugins/transform/common/constants.ts b/x-pack/plugins/transform/common/constants.ts
@@ -77,14 +77,15 @@ export const APP_CREATE_TRANSFORM_CLUSTER_PRIVILEGES = [
 
 export const APP_INDEX_PRIVILEGES = ['monitor'];
 
-// reflects https://github.com/elastic/elasticsearch/blob/master/x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/dataframe/transforms/DataFrameTransformStats.java#L243
+// reflects https://github.com/elastic/elasticsearch/blob/master/x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/transform/transforms/TransformStats.java#L250
 export const TRANSFORM_STATE = {
   ABORTING: 'aborting',
   FAILED: 'failed',
   INDEXING: 'indexing',
   STARTED: 'started',
   STOPPED: 'stopped',
   STOPPING: 'stopping',
+  WAITING: 'waiting',
 } as const;
 
 const transformStates = Object.values(TRANSFORM_STATE);

diff --git a/...nsform/public/app/sections/transform_management/components/transform_list/use_columns.tsx b/...nsform/public/app/sections/transform_management/components/transform_list/use_columns.tsx
@@ -30,13 +30,15 @@ import { TRANSFORM_STATE } from '../../../../../../common/constants';
 import { getTransformProgress, TransformListRow, TRANSFORM_LIST_COLUMN } from '../../../../common';
 import { useActions } from './use_actions';
 
+// reflects https://github.com/elastic/elasticsearch/blob/master/x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/transform/transforms/TransformStats.java#L250
 const STATE_COLOR = {
   aborting: 'warning',
   failed: 'danger',
   indexing: 'primary',
   started: 'primary',
   stopped: 'hollow',
   stopping: 'hollow',
+  waiting: 'hollow',
 } as const;
 
 export const getTaskStateBadge = (
@@ -202,13 +204,15 @@ export const useColumns = (
             {!isBatchTransform && (
               <Fragment>
                 <EuiFlexItem style={{ width: '40px' }} grow={false}>
-                  {/* If not stopped or failed show the animated progress bar */}
+                  {/* If not stopped, failed or waiting show the animated progress bar */}
                   {item.stats.state !== TRANSFORM_STATE.STOPPED &&
+                    item.stats.state !== TRANSFORM_STATE.WAITING &&
                     item.stats.state !== TRANSFORM_STATE.FAILED && (
                       <EuiProgress color="primary" size="m" />
                     )}
-                  {/* If stopped or failed show an empty (0%) progress bar */}
+                  {/* If stopped, failed or waiting show an empty (0%) progress bar */}
                   {(item.stats.state === TRANSFORM_STATE.STOPPED ||
+                    item.stats.state === TRANSFORM_STATE.WAITING ||
                     item.stats.state === TRANSFORM_STATE.FAILED) && (
                     <EuiProgress value={0} max={100} color="primary" size="m" />
                   )}