Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Transforms: Fix waiting state in transforms list. #98592

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Apr 28, 2021

Summary

Follow up to #93956.
Fixes #98444.
Fixes #74837.

When no transform nodes are available, existing continuous transform end up in a waiting state. This PR adds support for this state in the transforms UI. Without the fix, transforms in a waiting state would fail to show up in the transform list.

The waiting state was added in Elasticsearch here: elastic/elasticsearch#70139

Testing instructions:

  • With the transform role enabled, create and start a continuous transform
  • Quit ES and change its config to not include the transform role like:
node.roles: [
  "master",
  "data",
  "data_content",
  "data_hot",
  "data_warm",
  "data_cold",
  "data_frozen",
  "ingest",
  "ml",
  "remote_cluster_client",
  # "transform",
]
  • Start ES+Kibana again, you should see the continuous transform in waiting state:

image

Checklist

@walterra walterra added bug Fixes for quality problems that affect the customer experience :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Transforms ML transforms v7.14.0 v7.13.0 labels Apr 28, 2021
@walterra walterra requested a review from a team as a code owner April 28, 2021 11:49
@walterra walterra self-assigned this Apr 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
transform 910.1KB 910.2KB +123.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 29, 2021
@walterra walterra merged commit 42d361c into elastic:master Apr 29, 2021
@walterra walterra deleted the ml-transform-fix-no-nodes-list branch April 29, 2021 08:17
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 29, 2021
When no transform nodes are available, existing continuous transform end up in a waiting state. This PR adds support for this state in the transforms UI. Without the fix, transforms in a waiting state would fail to show up in the transform list.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 29, 2021
When no transform nodes are available, existing continuous transform end up in a waiting state. This PR adds support for this state in the transforms UI. Without the fix, transforms in a waiting state would fail to show up in the transform list.
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.13
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 29, 2021
When no transform nodes are available, existing continuous transform end up in a waiting state. This PR adds support for this state in the transforms UI. Without the fix, transforms in a waiting state would fail to show up in the transform list.

Co-authored-by: Walter Rafelsberger <[email protected]>
kibanamachine added a commit that referenced this pull request Apr 29, 2021
When no transform nodes are available, existing continuous transform end up in a waiting state. This PR adds support for this state in the transforms UI. Without the fix, transforms in a waiting state would fail to show up in the transform list.

Co-authored-by: Walter Rafelsberger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Transforms ML transforms :ml release_note:skip Skip the PR/issue when compiling release notes v7.13.0 v7.14.0 v8.0.0
Projects
None yet
4 participants