Skip to content

Commit

Permalink
[Logs Explorer] Functional tests: Complete cleanup before continuing …
Browse files Browse the repository at this point in the history
…with the next tests (elastic#175517)

This [functional
test](https://github.com/elastic/kibana/blob/b25407edba0bb146c37d74b24e01d8c6367bfa64/x-pack/test/functional/apps/observability_log_explorer/dataset_selector.ts#L311)
was failing locally, as it was expecting the integration to be `Apache
HTTP Server` but was in fact `1password`. This is because the previous
test loads more integrations (than the original 3) and sometimes it
doesn’t clean up in time before the next test runs.

This PR adds `await` on the async
[cleanupAdditionalSetup](https://github.com/elastic/kibana/blob/main/x-pack/test/functional/apps/observability_log_explorer/dataset_selector.ts#L298)
call to complete the cleanup before continuing with other tests.
  • Loading branch information
gbamparop authored Jan 25, 2024
1 parent 5dd347b commit 238bdb3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(nodes.length).to.be(20);
});

cleanupAdditionalSetup();
await cleanupAdditionalSetup();
});

describe('clicking on integration and moving into the second navigation level', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(nodes.length).to.be(20);
});

cleanupAdditionalSetup();
await cleanupAdditionalSetup();
});

describe('clicking on integration and moving into the second navigation level', () => {
Expand Down

0 comments on commit 238bdb3

Please sign in to comment.