[Logs Explorer] Functional tests: Complete cleanup before continuing with the next tests #175517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbamparop
added
the
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
tonyghiani
approved these changes
Jan 25, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.13.0
backport:skip
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…with the next tests (elastic#175517) This [functional test](https://github.com/elastic/kibana/blob/b25407edba0bb146c37d74b24e01d8c6367bfa64/x-pack/test/functional/apps/observability_log_explorer/dataset_selector.ts#L311) was failing locally, as it was expecting the integration to be `Apache HTTP Server` but was in fact `1password`. This is because the previous test loads more integrations (than the original 3) and sometimes it doesn’t clean up in time before the next test runs. This PR adds `await` on the async [cleanupAdditionalSetup](https://github.com/elastic/kibana/blob/main/x-pack/test/functional/apps/observability_log_explorer/dataset_selector.ts#L298) call to complete the cleanup before continuing with other tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functional test was failing locally, as it was expecting the integration to be
Apache HTTP Serverbut was in fact1password. This is because the previous test loads more integrations (than the original 3) and sometimes it doesn’t clean up in time before the next test runs.This PR adds
awaiton the async cleanupAdditionalSetup call to complete the cleanup before continuing with other tests.