-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native surfaces and unfolded registration refactoring #345
Open
akhanf
wants to merge
28
commits into
dev-v2.0.0
Choose a base branch
from
unfoldregv2
base: dev-v2.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: - make alternative script for volumetric subfield labelling that uses label_gifti intstead of label_nifti - the volumetric targets are all turned off for now until that is done, since the cropref space relies on the subfields - add some smoothing for native surfaces (maybe another PR) - verify that the unfoldreg warping is being performed properly (compare with images, or make a toy example) - try with a single subject atlas, where the atlas is defined on it's own unfolded tesselation instead of unfoldiso - could make some target rules to generate the files for this (e.g. the subject metrics in unfold 2d slice, along with native and unfold meshes)
- only one atlas from CLI instead of multiples (was using atlas[0] some places) - remove final transforms (not used with nativesurf workflow) - giftis only for atlas (needs updated multihist7 files - workflow to generate these in resources/atlas-v2 for now) - use unfoldedreg when the atlas has the metrics - option for dentate-based unfoldreg too (unused right now) TODO: - update atlas files (use another location for testing) - check unfoldreg warps - make nativesurf the default
passes all dry-run tests now
major fix for isosurfaces as was using wrong labels for nan (all background) when I should instead be useing the src/sink for the other coords (AP/PD). Also sets the sink label to 1.1 to eliminate the false boundary, and then also use nans to ignore the false boundary thats created where src and sink meet.. THis now produces hipp surfaces with no holes!
now produces nice sulcal/gyral maps with curvature
also testing out new hippunfold_deps container..
currently naming is as space-corobl, with no density wildcard.. could consider adding den-native..
- greedy used as default unfoldreg method for now - warping verified to be correct using some synthetic data locally (still unsure why the y-flip is needed when creating the itk warp, but oh well) - added containers for all rules TODO: upload bbhist atlas prototype
- adds quotes around url to avoid issues with special characters - note: bbhist linked here is a WIP (ie subfields gifti has some holes, need to dilate labels into bg before sampling from native surf)
NOTE: multihist7 uses the legacy metric files (converted from previous nifti to gifti, using the Snakefile in the zip), and ultimately should be replaced by native giftis by running hippunfold v2 on those datasets (once we have multi-atlas support)
also adds a dryrun test (since this was in github actions tests already)
we don't yet actually check to see if metrics exist before trying to run unfolded reg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major updates here are:
native surface reconstruction
surface-based atlases
unfolded registration
other updates
Maybe TODO here (if not then in another PR):
Things to do later in another PR