Fix quality action #237
Merged
Fix quality action #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Poetry v1.4.1, packages were required to use modern installation (see: python-poetry/poetry#7686). This is potentially problematic when relying on older versions of packages and for packages who are still using non-modern installers. This commit adds an additional step to disable that modern-installation requirement, which should get the workflow working again.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@akhanf mentioned that the quality action has been failing when trying to install a package (see here).
Turns out this is due to a change made in the latest version of Poetry (the actions workflow doesn't pin the Poetry version used). As of
v1.4.1, packages are required to use modern installation (see: python-poetry/poetry#7686). This is potentially problematic when relying on older versions of packages and for packages who are still using non-modern installers. This PR fixes this by adding an additional step to disable the modern-installation requirement in the Poetry config.Also used this PR as an opportunity to: