Fixed many usability issues with the CalendarDay field #2930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went down a rabbit hole with this one 😬 I think I probably caused most of these with #2424.
I also dropped the initial and on-invalid-input current-day default for the filter. Most filters don't match the default, and it's not really likely someone would want to use the current date anyway. It just meant having to clear the field first. As for falling back to the current day on an invalid value (which was bugged anyway!), that also felt completely arbitrary. Now it falls back to empty input (
""
).