Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to date-fns 2.x #2927

Merged
merged 4 commits into from
May 11, 2020
Merged

Upgrade to date-fns 2.x #2927

merged 4 commits into from
May 11, 2020

Conversation

Vultraz
Copy link
Contributor

@Vultraz Vultraz commented May 8, 2020

Implements #2922 Proposal 2. Relies on #2930.

@changeset-bot
Copy link

changeset-bot bot commented May 8, 2020

🦋 Changeset is good to go

Latest commit: cad986c

We got this.

This PR includes changesets to release 28 packages
Name Type
@keystonejs/demo-project-blog Major
@keystonejs/demo-project-meetup Major
@arch-ui/day-picker Major
@keystonejs/fields Major
@keystonejs/fields-datetime-utc Major
@keystonejs/list-plugins Major
@keystonejs/cypress-project-basic Major
@keystonejs/cypress-project-client-validation Major
@keystonejs/app-admin-ui Patch
@keystonejs/auth-passport Patch
@keystonejs/auth-password Patch
@keystonejs/field-content Patch
@keystonejs/fields-authed-relationship Patch
@keystonejs/fields-auto-increment Patch
@keystonejs/fields-markdown Patch
@keystonejs/fields-mongoid Patch
@keystonejs/fields-wysiwyg-tinymce Patch
@keystonejs/keystone Patch
@keystonejs/demo-custom-fields Patch
@keystonejs/demo-project-todo Patch
@keystonejs/cypress-project-access-control Patch
@keystonejs/cypress-project-login Patch
@keystonejs/cypress-project-social-login Patch
@keystonejs/api-tests Patch
@keystonejs/benchmarks Patch
@keystonejs/example-projects-nuxt Patch
@keystonejs/example-projects-starter Patch
@keystonejs/example-projects-todo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Vultraz
Copy link
Contributor Author

Vultraz commented May 9, 2020

Rebased on top of #2930

@Vultraz Vultraz changed the title [WIP] Upgrade to date-fns 2.x Upgrade to date-fns 2.x May 9, 2020
@Vultraz
Copy link
Contributor Author

Vultraz commented May 11, 2020

@timleslie rebased

Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we explicitly list in changeset which field-types and which arguments are impacted, preferably between the 1st and 2nd paragraphs. I know that CalendarDay - { format } changes, and presumably there's a few other cases that we should call out so that devs can easily scan their code for places they might need to change things.

@Vultraz
Copy link
Contributor Author

Vultraz commented May 11, 2020

Done.

Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Righto, have looked through all the code and I think it's all 👍

The only remaining change I think we should make is that all the changesets should be major. If someone does a patch update of the list-plugins package for example, it will possibly break if they haven't also updated their fields package.

@Vultraz
Copy link
Contributor Author

Vultraz commented May 11, 2020

Also done.

Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@timleslie timleslie merged commit e9a0de2 into keystonejs:master May 11, 2020
This was referenced May 11, 2020
@Vultraz Vultraz deleted the date-fns-2 branch May 11, 2020 18:11
ayush-goyal pushed a commit to HackGT/keystone that referenced this pull request May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants