-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to date-fns 2.x #2927
Upgrade to date-fns 2.x #2927
Conversation
🦋 Changeset is good to goLatest commit: cad986c We got this. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rebased on top of #2930 |
@timleslie rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we explicitly list in changeset which field-types and which arguments are impacted, preferably between the 1st and 2nd paragraphs. I know that CalendarDay - { format }
changes, and presumably there's a few other cases that we should call out so that devs can easily scan their code for places they might need to change things.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Righto, have looked through all the code and I think it's all 👍
The only remaining change I think we should make is that all the changesets should be major
. If someone does a patch
update of the list-plugins
package for example, it will possibly break if they haven't also updated their fields
package.
Also done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍
(cherry picked from commit e9a0de2)
Implements #2922 Proposal 2. Relies on #2930.