Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find nlohmann_json downstream if EDM4hep has support #379

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Oct 23, 2024

BEGINRELEASENOTES

  • Add an EDM4HEP_WITH_JSON cmake option (default ON) to be explicit about whether we want to build EDM4hep with JSON support or not.
    • Properly propagate this to downstream packages.
    • If set to OFF the edm4hep2json executable will not be built.

ENDRELEASENOTES

@tmadlener
Copy link
Contributor Author

There is a potential discussion point: Should we just build EDM4hep with JSON support unconditionally? Currently we make that dependent on whether we find nlohmann_json, which is not very explicit, and I would actually prefer to be explicit about that e.g. via an option.

@andresailer
Copy link
Collaborator

There is a potential discussion point: Should we just build EDM4hep with JSON support unconditionally? Currently we make that dependent on whether we find nlohmann_json, which is not very explicit, and I would actually prefer to be explicit about that e.g. via an option.

👍

CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@andresailer andresailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this in so quickly!

@tmadlener tmadlener enabled auto-merge (squash) October 23, 2024 14:38
@tmadlener tmadlener merged commit 18799da into key4hep:main Oct 23, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants