Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that bit numbers are different for tertiary vertices #378

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Oct 23, 2024

BEGINRELEASENOTES

  • Make sure that the bits used for secondary and tertiary vertex bits are actually different

ENDRELEASENOTES

@BrieucF thanks for the hint and spotting this.

@andresailer
Copy link
Collaborator

   
  -- Configuring done (2.7s)
  CMake Error at /home/runner/work/EDM4hep/EDM4hep/install/lib64/cmake/EDM4HEP/EDM4HEPTargets.cmake:61 (set_target_properties):
    The link interface of target "EDM4HEP::edm4hep" contains:
  
      nlohmann_json::nlohmann_json

I think we need a find_dependency(nlohmann_json) in our EDM4hepConfig if we build with json

(We are running into the change from here root-project/root#16703 where ROOT used to always do that)

@tmadlener
Copy link
Contributor Author

I have opened #379 to fix that.

@andresailer andresailer merged commit c6bc8f4 into key4hep:main Oct 23, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants