Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use readable-stream instead of through2 #1

Merged
merged 1 commit into from
Jun 21, 2015
Merged

Use readable-stream instead of through2 #1

merged 1 commit into from
Jun 21, 2015

Conversation

shinnn
Copy link
Collaborator

@shinnn shinnn commented Jun 21, 2015

This change reduces the package file size since readable-stream is one of the dependencies of through2. https://github.com/rvagg/through2/blob/v2.0.0/package.json#L23

@shinnn
Use readable-stream instead of through2
36d8657 
This change reduces the package file size since readable-stream is one
of the dependencies of through2.

github.com/rvagg/through2/blob/v2.0.0/package.json#L23
kevva added a commit that referenced this pull request Jun 21, 2015
@kevva
Merge pull request #1 from kevva/readable-stream
7644767 
Use readable-stream instead of through2
@kevva kevva merged commit 7644767 into master Jun 21, 2015
@kevva
Copy link
Owner

kevva commented Jun 21, 2015

Sexy.

@kevva kevva deleted the readable-stream branch June 21, 2015 11:32
@shinnn
Copy link
Collaborator Author

shinnn commented Jun 21, 2015

@kevva @sindresorhus Can we update your vinyl-related projects (e.g. gulp plugin) like this?

@sindresorhus
Copy link

Nah, I kinda like using through2 as its API is even simpler, and the savings you talk about are super minor. I'm gonna go through my gulp plugins and upgrade through2 tomorrow.

@shinnn
Copy link
Collaborator Author

shinnn commented Jun 21, 2015

@sindresorhus

Streams3 has a simplified constructor API (nodejs/readable-stream#102) and we can use it everywhere by using readable-stream v2.0.0. That seems enough simple for me and I think now through2 is almost finishing its roles in the point of simplicity.

@sindresorhus
Copy link

I'm aware, but through2 still have a tiny bit simpler API, so I don't really see the benefit of switching.

@shinnn
Copy link
Collaborator Author

shinnn commented Jun 21, 2015

@sindresorhus Also correct.

I'm gonna go through my gulp plugins and upgrade through2

👍

@shinnn
Copy link
Collaborator Author

shinnn commented Jun 21, 2015

the savings you talk about are super minor

True, if rvagg/through2#36 is merged.

@shinnn shinnn mentioned this pull request Aug 12, 2015
Merged
@shinnn shinnn mentioned this pull request Aug 23, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shinnn @kevva @sindresorhus